-
|
Is the navigation overflow supposed to turn into an X when open and remain a hamburger (three bars) when closed? Checking out master of this repo, it resolutely remains a hamburger when clicked, and I can't tell if its my browsers (Safari, Firefox, and Microsoft Edge) or if the code to perform that is just left over and not supposed to function. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Looks broken to me. The three bars are suppose to rotate and turn into an X. The CSS is there for it but my quick look at demo site shows it's not setting I'd have to look back at some commits, but there was a pull request some time ago that made changes to the greedy navigation. I wouldn't be surprised if that broke something then and was just missed. |
Beta Was this translation helpful? Give feedback.
-
|
Yup, definitely was missing a line of JavaScript that toggled the class when the menu button is clicked. Surprised it took 11 months for someone to notice it was broken! Fixed it in ee67ad9 |
Beta Was this translation helpful? Give feedback.
Looks broken to me. The three bars are suppose to rotate and turn into an X. The CSS is there for it but my quick look at demo site shows it's not setting
.closeon.naviconlike it used.I'd have to look back at some commits, but there was a pull request some time ago that made changes to the greedy navigation. I wouldn't be surprised if that broke something then and was just missed.