-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
google-plus comments provider #1092
Comments
Not sure what's going on. I'm not seeing any script errors. Only thing I can think of Google changed the API or deprecated something. To get this working originally I followed some instructions from a random blog post. I never could find official documentation from Google on how to embed G+ comments on a website. Wouldn't surprise me at all if they turned this feature off for new posts as they've been scaling back the whole G+ thing the last couple of years. If you can find some documentation on how to fix or implement it directly from the horse's mouth I'll happily apply it. |
This change fixed it. I am not familiar with how it loads the comment box so its not the most elegant. But let me know if you want the change and I can submit a pull request. zmsp/zmsp.github.io@23914d3 changes on _includes/comments.html
Pulled from here: https://floaternet.com/gcomments |
A PR with this fix would be great. |
Avoid Liquid failure when no pages with titles Fix issue mmistakes#1085 The user's config specified collections (incorrectly). Trying to build the site resulted in Jekyll failing due to a Liquid error. The error report did not suggest the cause of the error. Liquid fails with division by 0 when title_pages_size is 0. This fix guards that code by checking that title_pages is non-empty. To test: 1. Specify a Jekyll collection with no pages, and specify it as a JTD collection. 2. Build the site. 3. Check that the specified collection has no nav links to pages.
google-plus comments provider seems to be stuck on loading. Didn't really see any javascript error on console.
bundle update
.bundle exec jekyll build
.Environment informations
Latest minimal-mistakes version
OS: Windows: Chrome/Linux: Firefox
Steps to reproduce the behavior
To reproduce, try to add comments after enabling google-plus commenting.
page: zmsp.github.io/hardware/cryptocurrency/gfx-too-high/
repo: github.com/zmsp/zmsp.github.io
The text was updated successfully, but these errors were encountered: