Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecation warning with sass gem 3.5 #1114

Closed
3 of 5 tasks
dpron opened this issue Jul 14, 2017 · 8 comments
Closed
3 of 5 tasks

Deprecation warning with sass gem 3.5 #1114

dpron opened this issue Jul 14, 2017 · 8 comments

Comments

@dpron
Copy link

dpron commented Jul 14, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

  • Minimal Mistakes version: 4.4.2
  • github-pages or jekyll gem version: (straight from forked source)
  • Operating system: Mac 10.12.5

Expected behavior

Site builds without warnings

Steps to reproduce the behavior

rm Gemfile.lock
bundle update

(updates saas gem to 3.5.1)

build site - causes screens full of the following warnings

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("mixin-exists")) instead.

and

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("variable-exists")) instead.

if I force the saas gem back to 3.4.25 - warnings disappear.

Unfortunately warnings don't reference the exact file names.

@mmistakes
Copy link
Owner

If I had to guess it's due to one of the 3rd party mixins I'm using (Breakpoint, Susy, etc.). I'll see if I can track down which Sass partial is the issue and see if they have updated their libraries to get around the warnings.

@mmistakes
Copy link
Owner

@mmistakes
Copy link
Owner

Found the culprit, Susy 2's set of mixins.

These deprecation warnings are mostly harmless but figured I'd go ahead and upgrade to Susy 3 anyways. That project went through a fairly serious rewrite so I had to refactor a lot of the CSS I was using to build the theme's grid.

Everything looks good to me, but if anyone wants to test and verify I didn't break anything (specifically grid layouts in related posts, galleries, etc) give it a go.

To test you can replace the entire _sass folder with this one in the susy-3-upgrade branch. Or if you're using the theme gem replace gem "minimal-mistakes-jekyll" with this line:

gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :branch => "susy-3-upgrade"

bobwhitelock added a commit to bobwhitelock/bobwhitelock.co.uk that referenced this issue Jul 22, 2017
bobwhitelock pushed a commit to bobwhitelock/minimal-mistakes that referenced this issue Jul 23, 2017
…` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes mmistakes#1114
@wkc1986
Copy link

wkc1986 commented Jul 30, 2017

Merged updates from susy-3-upgrade, seems to work well.

@mmistakes
Copy link
Owner

Great, thanks for confirming @wkc1986. I'll get this merged into the next release.

@justinrummel
Copy link
Contributor

using the specific susy-3-upgrade branch eliminated the warnings for me too.

@mmistakes
Copy link
Owner

Good to hear @justinrummel. Kind of bummed with all the helper functions Susy removed with v3. All of the gallery mixins are gone which makes doing custom stuff a lot more involved. Especially for those who want to customize the columns. #623 #875

@mmistakes
Copy link
Owner

mmistakes commented Aug 3, 2017

Fixed in 4ba7ccc

duetosymmetry added a commit to duetosymmetry/web-site that referenced this issue Aug 3, 2017
BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this issue Aug 17, 2017
…` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes mmistakes#1114
StevenHaveman added a commit to StevenHaveman/4brunu_copytest that referenced this issue Apr 11, 2018
Trying to get rid of deprecation warnings as described here:
mmistakes/minimal-mistakes#1114
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
…` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes mmistakes#1114
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
…` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes mmistakes#1114
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
…` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes mmistakes#1114
yesterz pushed a commit to yesterz/yesterz.github.io-test that referenced this issue Aug 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants