-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Correct .page
width and padding to visually center
#1155
Comments
No way to go back. Susy 3 killed a lot of the mixins I used with the theme and just provides simplified functions. I'll have to see if I can match the math in places it changed. As long as the layout didn't break I'm cool with some differences. |
I've added a right margin to page class:
So it looks the same as before. Maybe it helps. |
@dev4223 That's close, but the math is still off. @justinrummel The original intention with was to have the main content appear centered on the page, with equal amounts of white space on the left and right. In the old version with Susy 2, the math wasn't exactly there, but it looked close visually. I'm going to take another stab at it to try and balance things out since Susy 3 simplified some things. Might be easier to get the math exact. |
.page
width and padding to visually center
- Center main content on page - Harmonize sidebar columns to be equal widths Fixes #1155
Pushed some improvements to get the page and archive layouts where I've always wanted them.
I haven't merged it into
|
Awesome! I'll try it out this morning |
Wanted to make sure I'm reading this correctly, you want the Table of Contents to be on the right hand side vs. being embedded with the text. I have an updated screenshot of my current site showing the difference:
If this is the case, it would be nice if TOC could be identified towards the bottom of the markdown, but aligned at the top right. Else, if you but the TOC on the first line you will see the title of the TOC on the main page when post.excerpt is used. ( example: http://cl.rummel.co/0W040k3s0b31 ) |
That's right. I wanted to push the TOC out of the main content block since it doesn't always flow well. For instance with code blocks it cuts part of them off. Moving it to the dead space on the right avoids all that. I pushed a fix that if you place the I tend to drop the TOC include in after the first paragraph to avoid being pulled into the auto-generated The TOC will be after the content, which defeats the purpose of it. Let me know your thoughts and if this works out with your existing content. |
Thanks for the fast turnaround!
|
Should be fixed now. I forgot to include a negative margin for the smaller screen sizes, so the TOC wasn't getting pushed to the right. |
flawless! Going to push it to my main site and let it bake in production. |
Nice. Thanks for testing! |
* Fix collapsed white-space above pagination links * Improve `page` and `archive` layout - Center main content on page - Harmonize sidebar columns to be equal widths Fixes #1155 * Update CHANGELOG and history * Position and align right sidebar with the top of the main content * Offset right sidebar at `$large` viewport * Add TOC bottom include test post * Add right sidebar styling edits to documentation site * Add TOC bottom include test post
* Fix collapsed white-space above pagination links * Improve `page` and `archive` layout - Center main content on page - Harmonize sidebar columns to be equal widths Fixes mmistakes#1155 * Update CHANGELOG and history * Position and align right sidebar with the top of the main content * Offset right sidebar at `$large` viewport * Add TOC bottom include test post * Add right sidebar styling edits to documentation site * Add TOC bottom include test post
* Fix collapsed white-space above pagination links * Improve `page` and `archive` layout - Center main content on page - Harmonize sidebar columns to be equal widths Fixes mmistakes#1155 * Update CHANGELOG and history * Position and align right sidebar with the top of the main content * Offset right sidebar at `$large` viewport * Add TOC bottom include test post * Add right sidebar styling edits to documentation site * Add TOC bottom include test post
* Fix collapsed white-space above pagination links * Improve `page` and `archive` layout - Center main content on page - Harmonize sidebar columns to be equal widths Fixes mmistakes#1155 * Update CHANGELOG and history * Position and align right sidebar with the top of the main content * Offset right sidebar at `$large` viewport * Add TOC bottom include test post * Add right sidebar styling edits to documentation site * Add TOC bottom include test post
* Fix collapsed white-space above pagination links * Improve `page` and `archive` layout - Center main content on page - Harmonize sidebar columns to be equal widths Fixes mmistakes#1155 * Update CHANGELOG and history * Position and align right sidebar with the top of the main content * Offset right sidebar at `$large` viewport * Add TOC bottom include test post * Add right sidebar styling edits to documentation site * Add TOC bottom include test post
bundle update
.bundle exec jekyll build
.Environment informations
github-pages
orjekyll
gem version: jekyll 3.5.1Expected behavior
Page width seems to have changed since 4.5 gem is released
Steps to reproduce the behavior
When viewing on a desktop machine you can see the class
.page
is set for:width: 83.05085%;
float: right;
margin-right: 0;
padding-left: 4.23729%;
padding-right: 16.94915%;
screenshot: http://cl.rummel.co/3g0P222s1m3m
w/ gem 4.5 running locally, I see things have changed due to Susy
float: right;
width: 83.0508474576%;
padding-left: 1.6949152542%;
padding-right: 1.6949152542%
screenshot: http://cl.rummel.co/2t3L1H0o3j2j
It seems like padding-left needs a multiplier of 2.5 and padding-right needs a multiplier of 10, unless the MM is changing the presentation intentionally. If so, is there a way to go back to the previous formatting but still using the current version of Susy?
The text was updated successfully, but these errors were encountered: