Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ui-text] zh-HK should be as same as zh-TW #1374

Closed
1 of 5 tasks
Covernel opened this issue Nov 30, 2017 · 2 comments
Closed
1 of 5 tasks

[ui-text] zh-HK should be as same as zh-TW #1374

Covernel opened this issue Nov 30, 2017 · 2 comments
Labels
Status: Accepted Type: Bug

Comments

@Covernel
Copy link

Covernel commented Nov 30, 2017 •
edited
Loading

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Environment informations

Nil

Expected behavior

zh-HK should be as same as zh-TW

Steps to reproduce the behavior

Nil

Reason

Hong Kong is as same as Taiwan using Traditional Chinese instead of Simplified Chinese
@mmistakes
Copy link
Owner

I don't speak any of these languages so I'll just have to take your word for it. Care to submit a pull request with the fix?

@erickguan
Copy link
Contributor

I can confirm this because Chinese Wikipedia uses similar approach.

@erickguan erickguan mentioned this issue Dec 7, 2017
Merged
nghiaxlee pushed a commit to nghiaxlee/nghiaxlee.github.io that referenced this issue Sep 22, 2024
@dependabot
chore(deps-dev): bump @types/yargs from 17.0.32 to 17.0.33 (mmistakes…
9b75faa 
…#1374)

Bumps [@types/yargs](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/yargs) from 17.0.32 to 17.0.33.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/yargs)

---
updated-dependencies:
- dependency-name: "@types/yargs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Status: Accepted Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erickguan @mmistakes @Covernel