Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Limitation in the no of images in gallery #402

Closed
adrianbradu opened this issue Jul 20, 2016 · 2 comments
Closed

Limitation in the no of images in gallery #402

adrianbradu opened this issue Jul 20, 2016 · 2 comments

Comments

@adrianbradu
Copy link

I like the gallery helper; However it looks like it is properly working with a maximum 9 of images in the gallery. So far the solution for this is to greate gallery1 and gallery2 in the YAML Front Matter then:

{%include gallery id="gallery1"%}
{%include gallery id="gallery2"%}

Is there any way to sort out this?
Thanks a lot

@mmistakes
Copy link
Owner

mmistakes commented Jul 20, 2016

Do you have an example of a gallery with > 9 images that isn't working? To my knowledge there's nothing in the gallery include's Liquid that is enforcing any sort of maximum amount of images.

@mmistakes
Copy link
Owner

mmistakes commented Jul 20, 2016

Looking at this closer appears there's a bug with some of my Liquid. Stay tuned for a fix...

Update: fixed, see commit below. Updated sample gallery page (.md source) as reference.

mmistakes added a commit that referenced this issue Jul 20, 2016
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close #402
cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close mmistakes#402
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close mmistakes#402
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this issue Jul 31, 2023
…arn/primer/css-15.1.0

Bump @primer/css from 14.4.0 to 15.1.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants