Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Hamburger" menu navicon doesn't transition to "X" #969

Closed
mmistakes opened this issue Apr 21, 2017 · 1 comment
Closed

"Hamburger" menu navicon doesn't transition to "X" #969

mmistakes opened this issue Apr 21, 2017 · 1 comment
Labels
Type: Bug

Comments

@mmistakes
Copy link
Owner

mmistakes commented Apr 21, 2017 •
edited
Loading

When menu button is clicked and open "hamburger" navicon should transition into an "X" to imply it can be closed.

screen shot 2017-04-21 at 6 29 26 pm

Toggle class="close" on <button> isn't working. Possibly regression during greedy nav refactor.

screen shot 2017-04-21 at 6 38 54 pm
@mmistakes
Copy link
Owner Author

mmistakes commented Apr 22, 2017 •
edited
Loading

Fixed in e0099ff

yesterz pushed a commit to yesterz/yesterz.github.io-test that referenced this issue Aug 16, 2023
@JorgenIvarsson
feat(i18n): added Swedish localization file (mmistakes#969)
fe70479 
Nice PR @JorgenIvarsson, everything from the branch name to the commit messages perfectly meets the requirements. Thanks!
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmistakes