Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not print the comments form #1195

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Do not print the comments form #1195

merged 3 commits into from
Aug 22, 2017

Conversation

lsolesen
Copy link
Contributor

No description provided.

@mmistakes
Copy link
Owner

I'd prefer not to hide comments as they can be considered "content" in a lot of cases.

Also, the preferred method to hiding would be to add the element you'd like to hide to _sass/minimal-mistakes/_print.scss.

@lsolesen
Copy link
Contributor Author

@mmistakes This is only hiding the comments form, not the comments themselves. I can revise to use markup instead, if you prefer.

@mmistakes
Copy link
Owner

Gotcha. Yes, please add the form class to _print.scss to hide instead of adding a no-print class to the HTML.

@mmistakes mmistakes merged commit 2939d45 into mmistakes:master Aug 22, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
Add `.page__comments-form` to "non-printing" selectors in print styles
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
Add `.page__comments-form` to "non-printing" selectors in print styles
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
Add `.page__comments-form` to "non-printing" selectors in print styles
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants