Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve translation for minute_read. #1211

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Improve translation for minute_read. #1211

merged 1 commit into from
Sep 1, 2017

Conversation

DDoSolitary
Copy link
Contributor

Although the original one can be understood, it seems strange for a native Chinese speaker. I think the updated version should be better.

@mmistakes
Copy link
Owner

How bad is the original one? I get a lot of these requests to change translated text for a given locale and it becomes a battle with people constantly submitting PRs to change it back and fourth.

The ui-text.yml data file is completely editable by the user. My intention was to provide a base line of texts and then its up to the user to tailor those to suit their site/needs.

@DDoSolitary
Copy link
Contributor Author

DDoSolitary commented Sep 1, 2017

I believe that any native Chinese speaker would say that the updated version is better (though
definitely not the best, I always fail my Chinese exams XD). But it is really difficult for me to explain how is it better.

I love your project and I just wanted to make this project better. At the same time, I understand that it's somewhat annoying to deal with such translation problems. It is up to you to decide whether to merge this PR.

@mmistakes mmistakes merged commit dddf865 into mmistakes:master Sep 1, 2017
@DDoSolitary DDoSolitary deleted the chinese-minute-read-patch branch September 1, 2017 14:35
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants