Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix google plus link #1319

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Fix google plus link #1319

merged 1 commit into from
Nov 6, 2017

Conversation

sumibi-yakitori
Copy link
Contributor

No description provided.

@mmistakes
Copy link
Owner

Can you give some detail on why this fix is needed? Google+ URLs with the + in them still exist and are valid. Example: https://plus.google.com/+MichaelRoseDesign.

@sumibi-yakitori
Copy link
Contributor Author

Hi

my google plus profile
https://plus.google.com/116211923005103602552

But this url is invalid
https://plus.google.com/+116211923005103602552

@mmistakes
Copy link
Owner

That makes sense then. I believe the + is for those who have set a vanity URL.

@sumibi-yakitori
Copy link
Contributor Author

I now know that google plus can make vanity url.
But my google plus account does not seem to be able to make vanity url.

You may reject this pull request.

@mmistakes
Copy link
Owner

I've accepted the PR and will merge it in when I get a chance.

It's probably better to omit the + as you have to allow anyone with a profile to use it.

@sumibi-yakitori
Copy link
Contributor Author

Thank you.

@mmistakes mmistakes merged commit cf9a908 into mmistakes:master Nov 6, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this pull request Sep 10, 2019
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants