-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix staticman v2/v3 comments not showing #2351
Conversation
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
FYI @mmistakes this was actually a breaking change. I had my blog's remote_theme: mmistakes/minimal-mistakes And never noticed until today that comments were no longer showing up on my blog. Before finding this PR, a quick fix was to do: remote_theme: mmistakes/minimal-mistakes@26c1989 Now that I see the actual change you applied, I'm sure I can update my staticman:
branch: "master"
endpoint: "https://MyEndpoint.herokuapp.com/v3/entry/github/" to (added 2 spaces in front of each line): staticman:
branch: "master"
endpoint: "https://MyEndpoint.herokuapp.com/v3/entry/github/" I'm posting the fix for others who come across this issue and find this PR. Just thought I'd mention this, as you may not have realized you were making a breaking change here, and may want to communicate it somehow in the ReadMe for others that discover their comments have suddenly gone missing. |
That’s one of the big drawbacks of using remote themes. Every commit to the repo has the possibility of breaking your site. This is why I encourage installing it by locking at specific versions or commits... as you’ve pointed out above. |
Yeah, I'll be locking it via commit message going forward. I also found a bug introduced by this PR and created the PR above to address it :) Thanks for your great theme and hard work! |
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
According to the most recent docs, `branch` and `endpoint` should be inside `site.comments.staticman` config.
This is a bug fix.
Summary
According to the most recent docs,
branch
andendpoint
should be insidesite.comments.staticman
config instead ofsite.staticman
.Context
https://mmistakes.github.io/minimal-mistakes/docs/configuration/#staticman-v3