Use relative_url and absolute_url where possible #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops the `contains "://"` check, adopt Jekyll 3.7 Ref: mmistakes#2385 (comment)
iBug
commented
Jan 29, 2020
iBug
force-pushed
the
use-relative-url
branch
from
67f5d7b
to
f7f50ac
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
|
Any ideas? @mmistakes |
mmistakes
reviewed
Mar 4, 2020
mmistakes
reviewed
Mar 4, 2020
mmistakes
requested changes
Mar 4, 2020
|
@mmistakes I assume you received notifications for the last commit? |
mmistakes
requested changes
Mar 5, 2020
mmistakes
approved these changes
Mar 5, 2020
|
Nice work on this one, everything looks good to me! |
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
* Use relative_url and absolute_url where possible Drops the `contains "://"` check, adopt Jekyll 3.7 Ref: mmistakes#2385 (comment) * One more unneeded {% assign %} * Remove one more assign as noted by mmistakes * Consolidate 4 more captures * Consolidate an extra assign on "active" class
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
* Use relative_url and absolute_url where possible Drops the `contains "://"` check, adopt Jekyll 3.7 Ref: mmistakes#2385 (comment) * One more unneeded {% assign %} * Remove one more assign as noted by mmistakes * Consolidate 4 more captures * Consolidate an extra assign on "active" class
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
* Use relative_url and absolute_url where possible Drops the `contains "://"` check, adopt Jekyll 3.7 Ref: mmistakes#2385 (comment) * One more unneeded {% assign %} * Remove one more assign as noted by mmistakes * Consolidate 4 more captures * Consolidate an extra assign on "active" class
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
* Use relative_url and absolute_url where possible Drops the `contains "://"` check, adopt Jekyll 3.7 Ref: mmistakes#2385 (comment) * One more unneeded {% assign %} * Remove one more assign as noted by mmistakes * Consolidate 4 more captures * Consolidate an extra assign on "active" class
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement or feature.
Summary
Since Jekyll 3.7.0 the
relative_urlfilter does nothing when given an absolute URL, which eliminates the need to manually check forurl contains "://". This saves a lot of effort when coding.A similar behavior for the
absolute_urlfilter had already been introduced earlier in jekyll/jekyll#5789 and was released with Jekyll 3.5.I ran both
grep -nrF 'contains "://"'andgrep -nrF "contains '://'"(single- vs. double-quotes) and reviewed every single occurrence of them, and refactored wherever possible / makes sense.Jekyll 3.6 would no longer be compatible with this theme after merging this PR.
Context
#2385 (comment)