Fix Linkedin social share link #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed url encoding of the article link
minyoongi96
pushed a commit
to minyoongi96/minyoongi96.github.io
that referenced
this pull request
Aug 26, 2024
Removed url encoding of the article link
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed url encoding of the article link
This is a bug fix.
Summary
Linkedin social share button does not seem to be working correctly when an article's URL is encoded (as in
/replaced with%2Fetc). I encountered this bug while trying to share my own article hosted on Github Pages. It does not seem to be the case with common websites, for examplehttps://google.com/seems to work both raw and encoded.Context
I didn't find any issue mentioning that bug - but the fix is quick and simple enough to go with the PR right away.