-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
A customizable skin #347
A customizable skin #347
Conversation
Great work on this pull request @alxddh! |
Thanks. Looking forward to your follow-up improvement. |
## Added - Add light and dark skins. [#347] - Add support for customizable skins. [#347] ## Fixed - Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [#341]
A customizable skin
## Added - Add light and dark skins. [mmistakes#347] - Add support for customizable skins. [mmistakes#347] ## Fixed - Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [mmistakes#341]
This is an enhancement or feature.
Summary
This PR implements a feature that users can make their skins.
I have moved all color-related properties into a single file
_sass/so-simple/_skin.scss
, and made a default skin fileassets/css/skins/default.scss
:A skin file would be referenced in the template
head.html
according to the user's configuration:If the user wants to use a custom skin, he or she just needs to copy
default.css
, and rename it, and override these color variables.I have also made two additional skins:
light.scss
anddark.scss
.I think this implementation is very flexible. Users can even select different skins according to different hours in a day, for example, they can write below scripts in their
head-custom.html
:Context
#344