Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix .omit() to work similarly to Omit #54

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

aryaemami59
Copy link
Collaborator

This PR:

  • Fixes .omit() to work similarly to Omit. This was done in a way that allows type hinting and intellisense to work without being too strict.
  • Resolves .omit does not work with unions #53.

@aryaemami59 aryaemami59 marked this pull request as ready for review March 11, 2024 08:44
@mmkal mmkal merged commit ab32eb4 into mmkal:main Mar 13, 2024
1 check passed
@mmkal
Copy link
Owner

mmkal commented Mar 13, 2024

Thanks @aryaemami59

@aryaemami59 aryaemami59 deleted the fix-omit branch March 13, 2024 21:46
kodiakhq bot referenced this pull request in X-oss-byte/Nextjs Apr 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [expect-type](https://github.com/mmkal/expect-type) | [`0.18.0` -> `0.19.0`](https://renovatebot.com/diffs/npm/expect-type/0.18.0/0.19.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/expect-type/0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/expect-type/0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/expect-type/0.18.0/0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/expect-type/0.18.0/0.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>mmkal/expect-type (expect-type)</summary>

### [`v0.19.0`](https://github.com/mmkal/expect-type/releases/tag/0.19.0)

[Compare Source](https://github.com/mmkal/expect-type/compare/0.18.0...0.19.0)

#### What's Changed

-   Fix `.omit()` to work similarly to `Omit` by [@&#8203;aryaemami59](https://github.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/54](https://github.com/mmkal/expect-type/pull/54)
-   Add JSDocs to everything by [@&#8203;aryaemami59](https://github.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/56](https://github.com/mmkal/expect-type/pull/56)
-   Remove `test` import in `README.md` by [@&#8203;aryaemami59](https://github.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/65](https://github.com/mmkal/expect-type/pull/65)

**Full Changelog**: mmkal/expect-type@0.18.0...0.19.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.omit does not work with unions
2 participants