Add alloc_with_options #1218

qinsoon · 2024-10-29T05:14:01Z

This PR adds an alternative allocation functions alloc_with_options. The attached AllocationOptions change the allocation behavior, such as avoiding GCs and allowing overcommit.

Our current alloc functions assume they are GC safe points and will trigger GCs internally. A runtime may have different assumptions. We see GHC has allocateMightFail (https://gitlab.haskell.org/ghc/ghc/-/blob/90746a591919fc51a0ec9dec58d8f1c8397040e3/rts/sm/Storage.c?page=2#L1089). Also Julia assumes perm alloc will not trigger a GC (mmtk/mmtk-julia#172).
Having a variant of alloc that is not GC safepoints could be generally useful.

wks

I changed parts of the doc comments of alloc, alloc_no_gc, alloc_slow and alloc_slow_no_gc. Particularly, I rewrote the comment of alloc to make it more ordered.

src/memory_manager.rs

qinsoon · 2024-10-30T23:33:01Z

I changed the documentation based on the suggestions.

k-sareen · 2024-10-30T23:36:33Z

src/memory_manager.rs

+/// normally without panicking or throwing exceptions, this function will return zero.
+///
+/// This function in most cases returns a valid memory address.
+/// This function may return a zero address iif 1. MMTk attempts at least one GC,


Suggested change

/// This function may return a zero address iif 1. MMTk attempts at least one GC,

/// This function may return a zero address if 1. MMTk attempts at least one GC,

Actually this paragraph should be removed.

src/util/alloc/allocator.rs

src/plan/mutator_context.rs

src/memory_manager.rs

src/util/alloc/allocator.rs

large object. Minor fixes for comments

src/policy/space.rs

src/memory_manager.rs

Co-authored-by: Kunshan Wang <wks1986@gmail.com>

wks

LGTM

qinsoon · 2024-11-01T08:25:44Z

I’m awaiting feedback from @JunmingZhao42 and Ben before merging this PR, as they requested this feature.

src/policy/space.rs

Co-authored-by: Ben Gamari <ben@smart-cactus.org>

wks · 2025-05-09T04:39:25Z

I think this PR still looks good now.

commit 8a6cac2 Author: Yi Lin <qinsoon@gmail.com> Date: Wed May 21 05:36:29 2025 +0000 Implement SpaceInspector for all policies commit 10883f4 Author: Yi Lin <qinsoon@gmail.com> Date: Thu May 15 04:38:07 2025 +0000 Introduce SpaceInspector and RegionInspector commit c5ead72 Author: Yi Lin <qinsoon@gmail.com> Date: Mon May 12 12:42:14 2025 +1200 Choose Non-moving Policy based on features (mmtk#1308) This PR uses an Immix space as the default non moving space, and adds two features to use mark sweep or immortal as the non moving space. * `Mutator` now includes 2 Immix allocators (one for Immix as the default space, and the other for Immix as the non moving space). * Call prepare/release/end_of_gc for the non moving space. * Add `common_prepare_func` and `common_release_func` for mutators. commit 8b32d04 Author: Yi Lin <qinsoon@gmail.com> Date: Fri May 9 17:41:07 2025 +1200 Add alloc_with_options (mmtk#1218) This PR adds an alternative allocation functions `alloc_with_options`. The attached `AllocationOptions` change the allocation behavior, such as avoiding GCs and allowing overcommit. Our current `alloc` functions assume they are GC safe points and will trigger GCs internally. A runtime may have different assumptions. We see GHC has `allocateMightFail` (https://gitlab.haskell.org/ghc/ghc/-/blob/90746a591919fc51a0ec9dec58d8f1c8397040e3/rts/sm/Storage.c?page=2#L1089). Also Julia assumes perm alloc will not trigger a GC (mmtk/mmtk-julia#172). Having a variant of `alloc` that is not GC safepoints could be generally useful. --------- Co-authored-by: Kunshan Wang <wks1986@gmail.com> Co-authored-by: Ben Gamari <ben@smart-cactus.org> commit df7a1f1 Author: Yi Lin <qinsoon@gmail.com> Date: Thu May 8 15:31:41 2025 +1200 Remove V8 tests from extended tests (mmtk#1313) This PR removes V8 tests from our extended tests for mmtk-core. The V8 version we use in the binding is outdated, and the required environments are no longer supported by Github runners. See the discussion in [#ANU Research > The V8 binding is beyond repair @ 💬](https://mmtk.zulipchat.com/#narrow/channel/262677-ANU-Research/topic/The.20V8.20binding.20is.20beyond.20repair/near/509115086).

Add alloc_no_gc

18379df

qinsoon marked this pull request as ready for review October 30, 2024 02:37

wks reviewed Oct 30, 2024

View reviewed changes

qinsoon added 2 commits October 30, 2024 23:21

Change comments according to the reviews

6b1ac05

Chagne the test case to make sure it triggers the failure case

c120f11

k-sareen reviewed Oct 30, 2024

View reviewed changes

alloc_no_gc will not call out_of_memory when allocating an erroneously

03dfc5a

large object. Minor fixes for comments

qinsoon added the PR-extended-testing Run extended tests for the pull request label Oct 31, 2024

wks reviewed Oct 31, 2024

View reviewed changes

src/policy/space.rs Outdated Show resolved Hide resolved

wks and others added 2 commits October 31, 2024 06:53

Split will_oom_on_acquire

0971cda

Cargo fmt

07a01c7

wks reviewed Oct 31, 2024

View reviewed changes

src/memory_manager.rs Outdated Show resolved Hide resolved

qinsoon and others added 2 commits November 1, 2024 15:01

Update src/memory_manager.rs

875968a

Co-authored-by: Kunshan Wang <wks1986@gmail.com>

Merge branch 'master' into alloc-no-gc

1749c50

wks approved these changes Nov 1, 2024

View reviewed changes

bgamari reviewed Nov 5, 2024

View reviewed changes

src/policy/space.rs Outdated Show resolved Hide resolved

qinsoon and others added 6 commits November 6, 2024 16:51

Update src/policy/space.rs

03515ce

Co-authored-by: Ben Gamari <ben@smart-cactus.org>

alloc_with_options to allow more variations to alloc

f5bfeaa

Merge branch 'master' into alloc-no-gc

9908c97

cargo fmt. Minor fixes

9ef9807

Update comments

c751f37

Add a test for overcommit

1c683c3

qinsoon changed the title ~~Add alloc_no_gc~~ Add alloc_with_options Feb 5, 2025

Merge branch 'master' into alloc-no-gc

8ba4618

qinsoon added this pull request to the merge queue May 9, 2025

Merged via the queue into mmtk:master with commit 8b32d04 May 9, 2025
31 of 33 checks passed

qinsoon deleted the alloc-no-gc branch May 9, 2025 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add alloc_with_options #1218

Add alloc_with_options #1218

Uh oh!

qinsoon commented Oct 29, 2024 •

edited

Loading

Uh oh!

wks left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qinsoon commented Oct 30, 2024

Uh oh!

k-sareen Oct 30, 2024

Uh oh!

qinsoon Oct 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wks left a comment

Uh oh!

qinsoon commented Nov 1, 2024

Uh oh!

Uh oh!

wks commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

	/// This function may return a zero address iif 1. MMTk attempts at least one GC,
	/// This function may return a zero address if 1. MMTk attempts at least one GC,

Add alloc_with_options #1218

Add alloc_with_options #1218

Uh oh!

Conversation

qinsoon commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qinsoon commented Oct 30, 2024

Uh oh!

k-sareen Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

qinsoon Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wks left a comment

Choose a reason for hiding this comment

Uh oh!

qinsoon commented Nov 1, 2024

Uh oh!

Uh oh!

wks commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

qinsoon commented Oct 29, 2024 •

edited

Loading