Skip to content

Print third-party heap version in -Xinternalversion and error report. #14

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 10, 2022

This PR adds hooks to invoke ThirdPartyHeap::version() in -Xinternalversion and in VM error reports.

@qinsoon qinsoon marked this pull request as ready for review August 11, 2022 00:56
@qinsoon qinsoon requested a review from wks August 11, 2022 00:56
Copy link
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small indentation problem.

@qinsoon
Copy link
Member Author

qinsoon commented Aug 12, 2022

I have fixed the indentation. I will update the OpenJDK revision in the binding side once this is merged (as it will have a new commit hash). @wks

Copy link
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit ad18091 into jdk-11.0.15+8-mmtk Aug 15, 2022
caizixian added a commit to caizixian/jdk that referenced this pull request Sep 15, 2022
caizixian added a commit to caizixian/jdk that referenced this pull request Sep 23, 2022
caizixian added a commit to caizixian/jdk that referenced this pull request Oct 19, 2022
caizixian added a commit to caizixian/jdk that referenced this pull request Oct 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants