-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
remove ioutil (fixes #106) #108
Conversation
Thanks @flowchartsman for this PR as well as for #109. I have been very hesitant in adopting new version of Go with this package. Replacing
I have not yet come to a conclusion and therefore I am not yet ready to review this PR nor merging it. So far, "breaking" changes have in this area have only been made for the introduction of Go modules (see the README.md). That being said, I think this PR would need to update the Additionally, the automated CI is no longer working (it still relies on travisci) and this should be moved to Github actions before we update to more recent version of Go. |
I'll probably throw that on, but, at least with this PR, my attitude is: the issue is still open, so now it has a PR. You can close it (or not) as you like, but now there's a whole PR if you want it. I just happen to be using Pigeon in a project right now, and the lint errors were annoying me. :) Given the Go Compatibility guaranteed, it really doesn't matter, though I will say the code is a heck of a lot more pleasant to look at with #109 in place. |
Sure. I mean, I ran all the tests in a couple versions of Go, but it's easy enough to move to Github actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #106