Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Doc search on website is broken #8705

Closed
hoechenberger opened this issue Jan 7, 2021 · 7 comments · Fixed by #8742
Closed

Doc search on website is broken #8705

hoechenberger opened this issue Jan 7, 2021 · 7 comments · Fixed by #8742

Comments

@hoechenberger
Copy link
Member

The search doesn't work for me anymore in the dev documentation. Stable is still functional.

https://mne.tools/dev/search.html?q=compute_rank

doesn't produce any results and the JS console throws an exception, ReferenceError: Can't find variable: Stemmer

I'm using Safari 14.0.2

cc @drammock

@drammock
Copy link
Member

This is now true of the stable site as well. Upstream reports 8623 and 8603 both say it's a theme problem, not a core sphinx problem. I spent some time today trying to locally fix it by copying the fix from the sphinx-rtd theme and a couple other things, but it didn't work. Might be time to prioritize #8184 ASAP? Unless someone else claims it I'll take a look tomorrow to see just how painful it would be to transition to the pydata theme.

@larsoner
Copy link
Member

Did you try porting the sphinx_rtd_theme fix to sphinx_bootstrap_theme (what I assume we use under the hood)? I don't think #8184 will be very easy...

@drammock
Copy link
Member

Yes, that's what I was trying to say before. It's a one line change, and it didn't work.

@agramfort
Copy link
Member

agramfort commented Jan 13, 2021 via email

@larsoner
Copy link
Member

Latest versions of sphinx_rtd_theme, for people that use it -- we don't. So we need to figure out which extension / code is causing our problem, and fix it wherever that is.

@larsoner
Copy link
Member

It's a one line change, and it didn't work.

I tried locally to make the change in sphinx_bootstrap_theme and it seemed to work -- maybe you changed a line in the wrong spot, or didn't make clean (or at least kill search.html) between tests or something? Will open a PR to test on CircleCI locally to confirm, upstream PR is ryan-roemer/sphinx-bootstrap-theme#213

@drammock
Copy link
Member

maybe you changed a line in the wrong spot, or didn't make clean

I definitely did make clean and it's hard to believe that I pasted in the wrong spot... but who knows. It was late in the day and I was ready for dinner so many levels of stupidity are possible under those conditions 😂

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants