Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search never stops searching, fails #8623

Closed
pedrohdz opened this issue Dec 30, 2020 · 7 comments
Closed

Search never stops searching, fails #8623

pedrohdz opened this issue Dec 30, 2020 · 7 comments

Comments

@pedrohdz
Copy link

Describe the bug
From 3.4.0 on, it seems as if the search functionality is broken.

The error found in the browser console:

Uncaught ReferenceError: Stemmer is not defined
    query http://localhost:8000/_static/searchtools.js:158
    setIndex http://localhost:8000/_static/searchtools.js:98
    <anonymous> http://localhost:8000/search/?q=jenkin&check_keywords=yes&area=default# line 2 > injectedScript:1

This issue seems to be directly related to the fix for #8419 in PR #8445.

To Reproduce
Steps to reproduce the behavior:

  1. Create a site using 3.4.0 or later.
  2. Try and search for something on the site.
  3. Watch the search page run for ever...

Expected behavior

For search to function.

Environment info

  • Docker image with:
    FROM sphinxdoc/sphinx:latest
    

Workaround
Pin to version 3.3.1 or earlier.

@tk0miya
Copy link
Member

tk0miya commented Dec 30, 2020

Are you using sphinx_rtd_theme? If so, it was already fixed by sphinx_rtd_theme. Please install it from the its repository. see readthedocs/sphinx_rtd_theme#1021.
refs: #8603.

@pedrohdz
Copy link
Author

I am using that theme! I will give it a try on Monday. I will update the issue then.

Thank you so much for the quick response!

@pedrohdz
Copy link
Author

pedrohdz commented Jan 4, 2021

That did this trick! Thanks again for the quick response @tk0miya!

@stsewd
Copy link
Contributor

stsewd commented Jan 4, 2021

Hi everyone I'll see if I can cut a new release of the theme this week!

@stsewd
Copy link
Contributor

stsewd commented Jan 4, 2021

Just released 0.5.1 https://pypi.org/project/sphinx-rtd-theme/ Let us know if that works!

@pedrohdz
Copy link
Author

pedrohdz commented Jan 5, 2021

Works! Thank you @stsewd! I appreciate the quick response!

@tk0miya
Copy link
Member

tk0miya commented Jan 5, 2021

Congrats!

lunkwill42 added a commit to Uninett/nav that referenced this issue Mar 18, 2021
Because:
- A bug in Sphinx 3.4 seems to cause the docs search function to stop
  working: sphinx-doc/sphinx#8623
- Locking on to the 3.3.1 version is an acceptable workaround for now..

Fixes #2270
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants