Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix platform argument #2057

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tokou
Copy link
Contributor

@tokou tokou commented Sep 15, 2024

Proposed changes

  • Fix issue with platform not working for iOS
    • This was due to selectDevice being passed the platform as well as a deviceId corresponding to the first available device
    • The fix is to filter available devices on the given platform if passed. Which makes sense
  • Add test specific platform and device argument in order to facilitate commands like maestro test flow.yml --platform android which did not work before

Testing

  • Run commands with 1 android and 1 iOS device running
    • maestro test flow.yml --platform android
    • maestro test flow.yml --platform ios
    • maestro --platform android test flow.yml
    • maestro --platform ios test flow.yml
    • maestro --platform android test flow.yml --platform ios
    • maestro test flow.yml --platform ios --device emulator-5554
    • maestro test flow.yml

Issues fixed

Fixes #2037

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--platform argument doesn't work
1 participant