Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Downgrade to nodejs 20.5.1 and keep it to avoid the build failure #1084

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Downgrade to nodejs 20.5.1 and keep it to avoid the build failure #1084

merged 2 commits into from
Sep 5, 2023
+14 −1

Conversation

kachick
Copy link
Member

@kachick kachick commented Sep 5, 2023 •
edited
Loading

Fixes #1083

  • Add build job in CI to prevent similar problems
  • Fix (or revert) problems

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Visit the preview URL for this PR (updated for commit 5b7c686):

https://mobu-waiwai--pr1084-fix-build-in-latest-h33auq7q.web.app

(expires Tue, 12 Sep 2023 10:19:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 295e29f2bd6fa9acc70abd1b84aec0de70cff3f6

@kachick kachick marked this pull request as ready for review September 5, 2023 10:25
@kachick
Copy link
Member Author

kachick commented Sep 5, 2023

As I understand nodejs/node#49497, this is a nodejs bug.

So we can wait for new release of nodejs v20.6.1 or higher ☕.

Thanks @nicolo-ribaudo for sharing it with us 🙏

@kachick kachick merged commit e79ba0b into main Sep 5, 2023
@kachick kachick deleted the fix-build-in-latest-nodejs branch September 5, 2023 10:25
@kachick kachick mentioned this pull request Sep 5, 2023
Merged
1 task
@kachick kachick changed the title Fix build step with nodejs 20.6.0 Downgrade to nodejs 20.5.1 and keep it to avoid the build failure Sep 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in latest deploy action
1 participant
@kachick