test: buildkitd version output and binary size #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Aug 19, 2024
|
|
||
| for _, br := range list { | ||
| for _, tc := range testCases { | ||
| for _, mv := range matrix { |
There was a problem hiding this comment.
We also need to add run-count in here . So BenchA/ref=foo/run=1, BenchA/ref=foo/run=2 to have multiple iterations.
There was a problem hiding this comment.
I guess we should not use -count in https://github.com/moby/buildkit-bench/pull/2/files#diff-ecedb817abdf33fd9ee7bb0c35c9cfcedfb39d8f3b261d92a6254066578aff08R38 then?
There was a problem hiding this comment.
Made some changes, see last commit
crazy-max
force-pushed
the
test-version-output
branch
7 times, most recently
from
718ea76 to
bcef3e4
Compare
tonistiigi
reviewed
Aug 19, 2024
crazy-max
force-pushed
the
test-version-output
branch
from
bcef3e4 to
d073ee7
Compare
crazy-max
changed the title
crazy-max
force-pushed
the
test-version-output
branch
from
d073ee7 to
30369fd
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
test-version-output
branch
3 times, most recently
from
bba881a to
635dc7a
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
test-version-output
branch
from
635dc7a to
ef01264
Compare
|
Get this one in to continue work on #6 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.