http: Support authentication #5733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/llb
area/testing
area/client
area/solver
area/source
labels
marxarelli
force-pushed
the
feature/http-auth
branch
from
eda0a76 to
62a9c5e
Compare
Support authentication for HTTP sources. - llb: Define general `llb.AuthOption` interface composed of `HTTPOption` and `GitOption`. - llb: Refactor `llb.AuthHeaderSecret` to return an `llb.AuthOption` so it may be used with both `llb.Git` and `llb.HTTP`. - llb: Define `HTTPInfo.AuthHeaderSecret`. - llb: Define and flag new `source.http.auth` capability when `HTTPInfo.AuthHeaderSecret` is set. - solver: Define new `http.auth` source attribute. - source/http: If an `http.auth` attribute is specified, resolve a secret named by its value and set the "Authorization" request header. Signed-off-by: Dan Duvall <dduvall@wikimedia.org>
marxarelli
force-pushed
the
feature/http-auth
branch
from
62a9c5e to
4deb760
Compare
marxarelli
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support authentication for HTTP sources.
llb.AuthOptioninterface composed ofHTTPOptionandGitOption.llb.AuthHeaderSecretto return anllb.AuthOptionso it may be used with bothllb.Gitandllb.HTTP.HTTPInfo.AuthHeaderSecret.source.http.authcapability whenHTTPInfo.AuthHeaderSecretis set.http.authsource attribute.http.authattribute is specified, resolve a secret named by its value and set the "Authorization" request header.