Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dockerfile: error out if device feature not used in labs #5738

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

crazy-max
Copy link
Member

No description provided.

@crazy-max crazy-max force-pushed the dockerfile-device-error-nolabs branch 2 times, most recently from 3ba2011 to 6ce93e1 Compare February 13, 2025 20:45
@tonistiigi tonistiigi marked this pull request as ready for review February 13, 2025 22:15
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be maybe bit better if this was handled in the parser stage but don't know why this wouldn't work as well.

@tonistiigi tonistiigi added this to the v0.20.0 milestone Feb 13, 2025
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the dockerfile-device-error-nolabs branch from 6ce93e1 to 7fd5f5c Compare February 13, 2025 22:20
@tonistiigi tonistiigi merged commit c45cd57 into moby:master Feb 13, 2025
103 of 104 checks passed
@crazy-max crazy-max deleted the dockerfile-device-error-nolabs branch February 14, 2025 00:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants