Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docker push should support --quiet flag #36655

Closed
nathanleclaire opened this issue Mar 21, 2018 · 5 comments · Fixed by docker/cli#2197
Closed

docker push should support --quiet flag #36655

nathanleclaire opened this issue Mar 21, 2018 · 5 comments · Fixed by docker/cli#2197
Labels
area/cli area/distribution kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. platform/desktop

Comments

@nathanleclaire
Copy link
Contributor

nathanleclaire commented Mar 21, 2018

I'm on latest Docker for Mac. It would be quite nice if docker push had a quiet mode, similar to how curl has -q to avoid showing the download-in-progress animations. I like the push output for working directly with docker but not for shell scripts.

@thaJeztah thaJeztah added area/cli kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Mar 22, 2018
@thaJeztah
Copy link
Member

A --quiet option for docker pull is being worked on in docker/cli#882 (not yet for push, but I agree we should probably have it for both.

Meanwhile, to suppress the progress bars, the same trick as for docker pull could be used as a workaround (see #13588 (comment))

docker push <image> | cat

@nathanleclaire could you perhaps reopen this in the docker/cli issue tracker (https://github.com/docker/cli/issues), because that's where the change will have to be made

@nathanleclaire
Copy link
Contributor Author

Sure!

@ghost
Copy link

ghost commented Jan 24, 2020

Wouldn't that swallow errors?

@thaJeztah
Copy link
Member

For easier discovery; this was implemented in docker/cli#2197, and will be in the next release of docker (no ETA yet, but the release after 19.03)

@BarakBD-Globality Hm.. yes, it should still print errors, but looks like there's a bug/oversight there:

Without --quiet

$ docker push nosuchimage
The push refers to repository [docker.io/library/nosuchimage]
An image does not exist locally with the tag: nosuchimage

echo $?
1

$ docker push busybox
The push refers to repository [docker.io/library/busybox]
195be5f8be1d: Layer already exists
[DEPRECATION NOTICE] registry v2 schema1 support will be removed in an upcoming release. Please contact admins of the docker.io registry NOW to avoid future disruption. More information at https://docs.docker.com/registry/spec/deprecated-schema-v1/
errors:
denied: requested access to the resource is denied
unauthorized: authentication required

echo $?
1

With --quiet:

$ docker push --quiet nosuchimage
docker.io/library/nosuchimage

$ echo $?
0

$ docker push --quiet busybox
docker.io/library/busybox

$ echo $?
0

I'll open a bug-report in docker/cli and post the link here

@thaJeztah
Copy link
Member

Opened docker/cli#2284

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/cli area/distribution kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. platform/desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants