Add support for docker push --quiet #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justyn Temme <justyntemme@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @silvin-lubecki @kolyshkin PTAL |
|
yeet |
This was referenced Jan 24, 2020
thaJeztah
commented
Jan 24, 2020
| @@ -66,5 +68,9 @@ func RunPush(dockerCli command.Cli, opts pushOptions) error { | |||
| } | |||
|
|
|||
| defer responseBody.Close() | |||
| return jsonmessage.DisplayJSONMessagesToStream(responseBody, dockerCli.Out(), nil) | |||
| if !opts.quiet { | |||
| return jsonmessage.DisplayJSONMessagesToStream(responseBody, dockerCli.Out(), nil) | |||
There was a problem hiding this comment.
Looks like actual push errors are produced here, so skipping this caused errors to not be printed, and docker push _always returning a zero-status exit code ("success") when using --quiet
See #2284
Mahoney
added a commit
to Mahoney-playground/goos
that referenced
this pull request
Apr 18, 2020
Coming in 20.03.0 - see docker/cli#2197
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
+ Add support for docker push --quiet- A picture of a cute animal (not mandatory but encouraged)