This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Add ability to overwrite images used for outputs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justincormack was this along the line of what you had in mind? |
rn
force-pushed
the
mkimage
branch
2 times, most recently
from
67b5d58 to
02c7755
Compare
We currently hardcode the Linuxkit/mkimage- images. This has the unfortunate consequence that, if we update the LinuxKit image used to generate the output, we have to update the Moby tool and then vendor it back into the LinuxKit repository. This commit introduces UpdateOutputImages() which allows a client of the Moby tools package to selectively overwrite the packages used to generate the outputs. Signed-off-by: Rolf Neugebauer <rolf.neugebauer@gmail.com>
justincormack
approved these changes
Apr 13, 2018
|
Yes that looks fine. We can easily change this in future if needed so I think its fine, but it gives the client more control. |
|
I think it would be nice to extend this in the future to allow clients to add new output formats too but need to think a bit more about the API. |
|
Yes, the main issue is the somewhat messy variation in input formats. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently hardcode the Linuxkit/mkimage- images. This has the
unfortunate consequence that, if we update the LinuxKit image used
to generate the output, we have to update the Moby tool and then
vendor it back into the LinuxKit repository.
This commit introduces UpdateOutputImages() which allows a client
of the Moby tools package to selectively overwrite the packages
used to generate the outputs.
We keep the full image names (name + tag) intact in the source
to make it easier to update them with 'sed'. From the image names
we generate a map which can be updated with UpdateOutputImages().
See: #211 (comment)
Signed-off-by: Rolf Neugebauer rolf.neugebauer@gmail.com