This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Add 'kernel+squashfs' output format #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
src/moby/output.go
Outdated
| return err | ||
| } | ||
| case "boot/ucode.cpio": | ||
| // skip this entry |
There was a problem hiding this comment.
it may be better to skip any other file under boot/ as if any are added you don't keep the directory so will cause issues. Or leave the empty directory?
There was a problem hiding this comment.
I copied the pattern from here: https://github.com/moby/tool/blob/master/src/initrd/initrd.go#L137
Pushed a fix and also changes initrd.go accordingly
This output produces a kernel and a root filesystem in squashfs format. squashfs is a read-only, compressed filesystem. The 'kernel+squashfs' output can be used in a similar way as the default 'kernel+initrd' output format with the benefit that the rootfs does not consume any memory. Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
For the initrd we only want to extract kernel, cmdline, and the ucode CPIO archive. Skip whatever is left in ./boot Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
justincormack
approved these changes
Apr 16, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This output produces a kernel and a root filesystem in squashfs format. squashfs is a read-only, compressed filesystem.
The 'kernel+squashfs' output can be used in a similar way as the default 'kernel+initrd' output format with the benefit that the rootfs does not consume any memory.
There is an additional commit which improves the logging for
dockerRun().The
linuxkit/mkimage-squashfsis already build and pushed.