fix: add file field for exports interface #5147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
Would appreciate a ton if you could take a look at this tiny PR when you have time, @JoshuaKGoldberg! |
Not yet 😉 I edited it just now. |
JoshuaKGoldberg
requested changes
Oct 30, 2024
There was a problem hiding this comment.
[Testing] The change looks good to me, but it'd be good to have test coverage. Could you please add one to exports.spec.js?
Even just a straightforward expect(this.test.file, 'to match', ...) would be fine enough IMO.
JoshuaKGoldberg
added
the
status: waiting for author
4 tasks
|
👋 just checking in @shadowusr, is this still something you have time & energy for? |
|
Closing out as it's been a couple months without activity. If someone wants to make their own PR, please go ahead - and remember to add co-author attribution if it includes significant code from this PR. Cheers! 🤎 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR adds
filefield to suites inExportsinterface, so that it matches other interfaces such as BDD.