Skip to content

Updates deprecated API endpoints #8

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Updates deprecated API endpoints #8

merged 3 commits into from
Mar 18, 2020

Conversation

rosemichaele
Copy link
Contributor

@rosemichaele rosemichaele commented Mar 18, 2020

The verify, control and expectations API endpoints in the latest version of this client are deprecated in the latest version of MockServer. This PR updates the endpoints, though perhaps a refreshed package generated by OpenAPI would be a more thorough solution.

Example:

expectation_api.expectation_put(expectation_hash)
PUT /expectation HTTP/1.1
Host: localhost
Accept: */*
User-Agent: OpenAPI-Generator/5.3.0/ruby
Content-Type: application/json
Content-Length: 309
HTTP/1.1 201 Created
version: 5.8.1
deprecated: "/expectation" is deprecated use "/mockserver/expectation" instead
connection: keep-alive
content-length: 0

Using this Ruby client:

PUT /expectation HTTP/1.1
Host: localhost
Accept: */*
User-Agent: OpenAPI-Generator/5.3.0/ruby
Content-Type: application/json
Content-Length: 309

HTTP/1.1 201 Created
version: 5.8.1
deprecated: "/expectation" is deprecated use "/mockserver/expectation" instead
connection: keep-alive
content-length: 0
@rosemichaele rosemichaele changed the title Updates deprecated expectations API endpoint Updates deprecated API endpoints Mar 18, 2020
@jamesdbloom jamesdbloom merged commit 1eb0e2f into mock-server:master Mar 18, 2020
Copy link
Contributor Author

@rosemichaele rosemichaele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #9 with the fix for this.

@@ -43,7 +43,7 @@ def bind_put_with_http_info(ports, opts = {})
fail ArgumentError, "Missing the required parameter 'ports' when calling ControlApi.bind_put"
end
# resource path
local_var_path = '/bind'
local_var_path = 'mockserver/bind'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading / is missing on these paths except for expectations. Apologies for the oversight - I tried to get them all updated, but only tested expectations.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants