correctly updates known classes after teaching estimators #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at solving issue #62.
Changing
_set_classes
to use other information in the learners (e.g. the labels of the given training data) than the classes known to the estimators broke tests, and was much more involved than moving the call to_set_classes
into a localteach
method to ensure the update happens after the training of the estimators.Unsure whether the whole description of the
teach
function should be repeated.