Enable Concrete Playback Unit tests to run with --cfg kani
#2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x-concrete-playback-cfg-kani
…x-concrete-playback-cfg-kani
karkhaz
suggested changes
Apr 6, 2023
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
adpaco-aws
reviewed
Apr 6, 2023
karkhaz
reviewed
Apr 6, 2023
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
karkhaz
approved these changes
Apr 6, 2023
adpaco-aws
approved these changes
Apr 6, 2023
tests/script-based-pre/playback_with_cfg_kani/sample_crate/src/main.rs
Outdated
Show resolved
Hide resolved
|
Thanks Jai for fixing this. I was also thinking that we could improve this logic by making the default the behaviour that is today activated by concrete playback. Instead of using I didn't want to suggest this before so this fix wouldn't get too big. But I think it would address @karkhaz important concern of cfg explosion. |
…/main.rs Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 19, 2023
* The Kani reference now includes an ["Attributes"](https://model-checking.github.io/kani/reference/attributes.html) section that describes each of the attributes available in Kani ([pull request](model-checking#2359) by @adpaco-aws) * Users' choice of SAT solver, specified by the `solver` attribute, is now propagated to the loop-contract synthesizer ([pull request](model-checking#2320) by @qinheping) * Unit tests generated by the concrete playback feature now compile correctly when using `RUSTFLAGS="--cfg=kani"` ([pull request](model-checking#2353) by @jaisnan) * The Rust toolchain is updated to 2023-02-18 ([pull request](model-checking#2384) by @tautschnig)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes #1610 by creating a
concrete_playbackfeature inkani_macros. Users can now call their unit tests with the command -RUSTFLAGS="--cfg=kani" cargo +nightly test.Resolved issues:
Resolves #1610
Call-outs:
Still need to pass
+nightlywith the tests. Already recorded in #1609.Testing:
How is this change tested? Regression tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.