Upgrade rust toolchain to 2023-04-30 #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked by #2457. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 30, 2023
With model-checking/kani#2456 we see examples where a pointer of a different type is byte-extracted from a union. This is caused by Rust's niche placement. `get_subexpression_at_offset` already catered for that, but we didn't use it in field expansion.
3 tasks
|
See #2457 (comment) for the link to the solution on the CBMC side. We might have to hold back on this upgrade until after the next CBMC release (due 2023-06-08). |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 31, 2023
With model-checking/kani#2456 we see examples where a pointer of a different type is byte-extracted from a union. This is caused by Rust's niche placement. `get_subexpression_at_offset` already catered for that, but we didn't use it in field expansion.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 31, 2023
With model-checking/kani#2456 we see examples where a pointer of a different type is byte-extracted from a union. This is caused by Rust's niche placement. `get_subexpression_at_offset` already catered for that, but we didn't use it in field expansion.
|
CBMC 5.85.0 has been released. A CBMC version bump PR should make this upgrade feasible. |
celinval
approved these changes
Jun 9, 2023
qinheping
approved these changes
Jun 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Push rust toolchain by one day to 2023-04-30.
Resolved issues:
Resolves #2451
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? Current regressions
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.