Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Escape Zero-size types in playback #2508

Conversation

YoshikiTakashima
Copy link
Contributor

@YoshikiTakashima YoshikiTakashima commented Jun 7, 2023

Description of changes:

This PR adds an escape in the concrete playback for zero-size types
where the previous implementation was crashing for.

Resolved issues:

Resolves #2453

Testing:

  • How is this change tested? c7f9044

  • Is this a refactor change? no

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@YoshikiTakashima YoshikiTakashima requested a review from a team as a code owner June 7, 2023 18:38
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@YoshikiTakashima YoshikiTakashima enabled auto-merge (squash) June 8, 2023 01:05
@YoshikiTakashima YoshikiTakashima disabled auto-merge June 8, 2023 02:53
@YoshikiTakashima
Copy link
Contributor Author

That's an interesting bug: 2 harnesses came out with exactly the same names... I'll investigate.

@YoshikiTakashima YoshikiTakashima enabled auto-merge (squash) June 8, 2023 12:51
@YoshikiTakashima
Copy link
Contributor Author

OK. This is a bug that is separate. It's the interaction between ZST and multi-harness. Tracking: #2509. I will merge this one with a reduced test case, and then fix that issue.

@YoshikiTakashima YoshikiTakashima merged commit cf203d3 into model-checking:main Jun 8, 2023
@YoshikiTakashima YoshikiTakashima deleted the yoshi-2453-crash-empty-result branch June 8, 2023 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concrete playback not working for Result<T, E> when T is ()
2 participants