Support for stubbing out foreign functions #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
force-pushed
the
extern-c-stubbing
branch
2 times, most recently
from
077ef36 to
fbc7abd
Compare
celinval
reviewed
Aug 3, 2023
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
fbc7abd to
0291658
Compare
JustusAdam
suggested changes
Aug 3, 2023
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
0291658 to
b46a20e
Compare
feliperodri
changed the title
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
b46a20e to
67bc1d3
Compare
JustusAdam
reviewed
Aug 4, 2023
celinval
reviewed
Aug 4, 2023
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
67bc1d3 to
db361fd
Compare
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
db361fd to
75de3f6
Compare
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
75de3f6 to
70aeb56
Compare
JustusAdam
approved these changes
Aug 8, 2023
celinval
reviewed
Aug 8, 2023
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
70aeb56 to
a487eac
Compare
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
feliperodri
force-pushed
the
extern-c-stubbing
branch
from
a487eac to
2d84403
Compare
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
celinval
reviewed
Aug 8, 2023
| pub fn transform_foreign_functions<'tcx>(tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) { | ||
| if let Some(stub_map) = get_stub_mapping(tcx) { | ||
| let mut visitor = | ||
| ForeignFunctionTransformer { tcx, local_decls: body.clone().local_decls, stub_map }; |
There was a problem hiding this comment.
you should do body.local_decls.clone() instead.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support for stubbing out foreign functions.
Resolved issues:
Resolves #2587.
Call-outs:
N/A.
Testing:
How is this change tested? Regression tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.