Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update toolchain to nightly 2023-08-04 #2661

Merged

Conversation

remi-delmas-3000
Copy link
Contributor

@remi-delmas-3000 remi-delmas-3000 commented Aug 4, 2023

Description of changes:

bump toolchain to nightly-2023-08-04

Call-outs:

Testing:

CI tests are passing. Built and tested on Apple M1.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@remi-delmas-3000 remi-delmas-3000 added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Aug 4, 2023
@remi-delmas-3000 remi-delmas-3000 changed the title Update toolchain to nightly 2023-08-03 Update toolchain to nightly 2023-08-04 Aug 4, 2023
@remi-delmas-3000 remi-delmas-3000 added Z-BenchCI Tag a PR to run benchmark CI and removed [C] Internal Tracks some internal work. I.e.: Users should not be affected. labels Aug 4, 2023
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I was just wondering if there's any specific reason why you updated our dependencies. If there's no reason, can you please revert those changes and push a separate PR?

BTW, thanks for fixing the documentation warnings. We should probably enforce no warnings in our CI but not here.

Thanks again!

@remi-delmas-3000
Copy link
Contributor Author

It looks good. I was just wondering if there's any specific reason why you updated our dependencies. If there's no reason, can you please revert those changes and push a separate PR?

BTW, thanks for fixing the documentation warnings. We should probably enforce no warnings in our CI but not here.

Thanks again!

there's a clang-format-14 reports formatting error on the vec.c stub, but I could not reproduce it locally so I could not fix.

Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remi-delmas-3000 !

here's a clang-format-14 reports formatting error on the vec.c stub, but I could not reproduce it locally so I could not fix.

Looks like it's been there for a while (seen it in other PRs) and our workflow is set to continue on errors from clang-format.

@adpaco-aws adpaco-aws marked this pull request as ready for review August 8, 2023 15:44
@adpaco-aws adpaco-aws requested a review from a team as a code owner August 8, 2023 15:44
@adpaco-aws adpaco-aws enabled auto-merge (squash) August 8, 2023 15:45
@adpaco-aws adpaco-aws merged commit 63f513f into model-checking:main Aug 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants