Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete obsolete stubs for Vec and related options #2770

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

The Vec stubs have been obsolete for 2+ years, are not getting tested in our CI, and the related options (--use-abs and --abs-type) don't work. The stubs code has bugs (e.g. the one pointed out in #2766). Since we're currently taking a different approach for stubbing (stubbing functions and methods as opposed to types), this PR removes all the Vec stubs and related functionality.

Resolved issues:

Resolves #697
Resolves #2766

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 15, 2023 16:52
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you please document this as a major change to the release notes? I don't think we need to add them to breaking changes, since this was an unstable option.

@zhassan-aws
Copy link
Contributor Author

Can you please document this as a major change to the release notes?

Done

@zhassan-aws zhassan-aws enabled auto-merge (squash) September 15, 2023 20:20
@zhassan-aws zhassan-aws merged commit 0fbe271 into model-checking:main Sep 15, 2023
@zhassan-aws zhassan-aws deleted the delete-stubs branch September 15, 2023 21:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with NoBackIter<T>::next in noback_vec Abstraction options not working
3 participants