Deprecate --visualize in favor of concrete playback
#3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We believe the `--visualize` is much harder to use than concrete playback. In the rare cases where a trace might be relevant, users can still use CBMC trace. For most users, this will simplify instalation since Kani will no longer require python.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We believe the
--visualizeis much harder to use than concrete playback. In the rare cases where a trace might be relevant, users can still use CBMC trace.For most users, this will simplify installation since Kani will no longer depend on Python3.
Note: As opposed to
--functionwhich was purely an internal feature, I believe we have mentioned--visualizeto users before, so I think it's important to have a deprecation period.Related #2832
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.