Hide --lib-c and add assume-false to unknown fns #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
requested changes
Mar 19, 2022
| @@ -79,7 +79,7 @@ impl KaniSession { | |||
| fn undefined_functions(&self, file: &Path) -> Result<()> { | |||
| let args: Vec<OsString> = vec
There was a problem hiding this comment.
Please add a test that checks this behavior, e.g.:
extern "C" {
fn missing_function() -> u32;
}
#[kani::proof]
fn main() {
unsafe {
let x = missing_function();
assert!(x == 5);
}
}The assert should be reported as unreachable. Without your change, it fails.
- Support to --lib-c is not well tested. Keep it as experiemental. - Change how CBMC behaves when a function that is not defined is reachable. This mitigates issues model-checking#576. We should still add an unimplemented assertion so we can flip the results of other checks to undetermined.
celinval
force-pushed
the
issue-576-mitigation
branch
from
246e45d to
56d6ff8
Compare
tedinski
approved these changes
Mar 22, 2022
zhassan-aws
approved these changes
Mar 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
- Support to --lib-c is not well tested. Keep it as experiemental. - Change how CBMC behaves when a function that is not defined is reachable. This mitigates issues model-checking#576. We should still add an unimplemented assertion so we can flip the results of other checks to undetermined.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
- Support to --lib-c is not well tested. Keep it as experiemental. - Change how CBMC behaves when a function that is not defined is reachable. This mitigates issues model-checking#576. We should still add an unimplemented assertion so we can flip the results of other checks to undetermined.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
- Support to --lib-c is not well tested. Keep it as experiemental. - Change how CBMC behaves when a function that is not defined is reachable. This mitigates issues model-checking#576. We should still add an unimplemented assertion so we can flip the results of other checks to undetermined.
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
- Support to --lib-c is not well tested. Keep it as experiemental. - Change how CBMC behaves when a function that is not defined is reachable. This mitigates issues #576. We should still add an unimplemented assertion so we can flip the results of other checks to undetermined.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
reachable. This mitigates issues Failing verification for proptest example using format! #576. We should still add an
unimplemented assertion so we can flip the results of other checks to
undetermined.
Resolved issues:
None
Call-outs:
I had to change the float test since fround() function is missing.
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.