Skip to content

NonZero (rotate_left, rotate_right, max, min, clamp, count_ones, cmp) Proofs #202

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

lang280
Copy link

@lang280 lang280 commented Dec 1, 2024

Working on #71 (Safety of NonZero)

We are looking for feedback on our proof for rotate_left & rotate_right.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@lang280 lang280 requested a review from a team as a code owner December 1, 2024 22:31
@lang280 lang280 changed the title NonZero (rotate_left & rotate_right) Proof for Contracts NonZero (rotate_left & rotate_right) Proof Dec 4, 2024
Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates!

@lang280 lang280 requested a review from tautschnig December 5, 2024 02:31
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a module for each function, can you move all of these harnesses inside of mod verify?

@lang280
Copy link
Author

lang280 commented Dec 10, 2024

Instead of having a module for each function, can you move all of these harnesses inside of mod verify?

Done! All in mod verify now

@carolynzech carolynzech changed the title NonZero (rotate_left & rotate_right) Proof NonZero (rotate_left, rotate_right, max, min, clamp, count_ones, cmp) Proofs Dec 10, 2024
@carolynzech carolynzech enabled auto-merge (squash) December 10, 2024 19:12
@tautschnig tautschnig disabled auto-merge December 10, 2024 20:53
@tautschnig tautschnig added this pull request to the merge queue Dec 10, 2024
Merged via the queue into model-checking:main with commit 367d8ff Dec 11, 2024
8 of 10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants