Skip to content

Fix: Handle SSE ping messages in WebFluxSseClientTransport #272

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goecho
Copy link

@goecho goecho commented May 28, 2025

  • Add check for SSE ping messages from fastMCP server
  • Log debug message when ping received instead of throwing exception
  • Complete the stream on ping events
  • Matches behavior of Python SDK which treats pings as keep-alive

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

- Add check for SSE ping messages from fastMCP server
- Log debug message when ping received instead of throwing exception
- Complete the stream on ping events
- Matches behavior of Python SDK which treats pings as keep-alive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant