Added functions read_resource and resource_templates from client/session.py to client/session_group.py #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in session but missing in session_group. TESTED=unit tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionalities to
client/session_group.pythat are present inclient/session.py.Motivation and Context
Saw this issue where the user wants capabilities to broadcast notification to all the connected clients from a server.
Saw a similar implementation on client side at
client/session_group.py. Wanted to make all the functions available here first, also helps me understand the how to implementserver/session_group.pybetter.If this looks good I can add the remaining functions to client session group first then create server session group.
How Has This Been Tested?
Tested through unit tests.
Breaking Changes
No.
Types of changes
Checklist