Update README.md #23
Draft
Update README.md #23
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still going through my exploration of the gem. These are the immediate friction points that prevented me from hitting the ground running. - Remove the controller from the gem module (avoid implicit relationship that is hard to diagnose) - Add missing module in tool example Hopefully it helps someone.
14113
reviewed
Jul 11, 2025
| render(json: server.handle_json(request.body.read).to_h) | ||
| end | ||
| class MyMcpController < ApplicationController | ||
| def index |
There was a problem hiding this comment.
I would suggest changing the index action (list of results) to show.
Suggested change
| def index | |
| def show |
|
After this PR, many changes have been made to the mcp gem and conflicts have occurred. If you are still interested, could you update it against the latest README? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still in the process of exploring the gem, and here are the initial challenges I've encountered that have slowed my progress.
server.handle_jsonseems to always return a String, I am still reading through the code, I'm I missing something? Is this expected?server.handle_jsonhave been returningnilwhen passed anotifications/initialized.Motivation and Context
Hopefully it helps someone. From 0 to 1 is there hard part in adopting a new gem.
How Has This Been Tested?
Playing around locally
Breaking Changes
Documentation only
Types of changes
Checklist