Skip to content

Remove unused initialization parameters from limiter blocks and DeadZone #2891

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2019
Merged

Remove unused initialization parameters from limiter blocks and DeadZone #2891

merged 2 commits into from
Apr 10, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 9, 2019

These parameters got obsoleted by #1012 for MSL 3.2.2 and #2561 for MSL 3.2.3, respectively.

@beutlich beutlich added the L: Blocks Issue addresses Modelica.Blocks label Apr 9, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Apr 9, 2019
@beutlich beutlich self-assigned this Apr 9, 2019
@beutlich beutlich force-pushed the remove-limitsAtInit branch from 5e41250 to 5ef9b60 Compare April 9, 2019 19:10
@beutlich beutlich marked this pull request as ready for review April 9, 2019 19:12
@beutlich beutlich changed the title Remove unused parameters limitsAtInit from limiter blocks and deadZoneAtInit from DeadZone block Remove unused initialization parameters from limiter blocks and DeadZone Apr 9, 2019
HansOlsson
HansOlsson approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@beutlich beutlich removed the request for review from casella April 10, 2019 19:12
@beutlich beutlich merged commit 7424a1b into modelica:master Apr 10, 2019
@beutlich beutlich deleted the remove-limitsAtInit branch April 10, 2019 19:12
@beutlich beutlich mentioned this pull request Jun 22, 2019
Closed
@beutlich beutlich added the task General work that is not related to a bug or feature label Jun 22, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MartinOtter MartinOtter MartinOtter approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
L: Blocks Issue addresses Modelica.Blocks task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@beutlich @MartinOtter @HansOlsson