Skip to content

Add top-level License annotation #4411

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add top-level License annotation #4411

wants to merge 1 commit into from

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jun 3, 2024

No description provided.

@beutlich beutlich added the requires Modelica 3.7 Issue that requires Modelica Language Specification 3.7 label Jun 3, 2024
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from 1672d49 to e29c4bf Compare June 3, 2024 18:55
tobolar
tobolar reviewed Jun 4, 2024
View reviewed changes
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from e29c4bf to a729680 Compare June 5, 2024 16:27
@tobolar
Copy link
Contributor

tobolar commented Jun 7, 2024

In the Modelica Spec v3.7-dev, there is both the annotation License and an annotation record of the same name (as a part of the Protection record). I'm confused...

Anyway, the suffix "-dev" feels like a development version of Spec. So why to implement it in MSL already now?

@beutlich
Copy link
Member Author

beutlich commented Jun 7, 2024

Yes, that's why it's labeled requires Modelica 3.7.

@beutlich beutlich force-pushed the add-top-level-license-annotation branch from a729680 to aaba440 Compare June 11, 2024 18:58
@tobolar
Copy link
Contributor

tobolar commented Jun 12, 2024

What I mean is that a development version (of Spec) is not a release and can still change. Maybe unlikely for the License annotation but who knows.

@beutlich
Copy link
Member Author

What I mean is that a development version (of Spec) is not a release and can still change. Maybe unlikely for the License annotation but who knows.

This just seems too unlikely given the voting results:

Voting on MCP-0029 has ended.

100% are in favor.

See mail to MD from Fri, 10 May 2024 14:35:17 +0200.

@beutlich beutlich force-pushed the add-top-level-license-annotation branch from aaba440 to 3b147e0 Compare June 19, 2024 19:37
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from 3b147e0 to 075f1f4 Compare July 19, 2024 19:36
@beutlich beutlich marked this pull request as draft July 19, 2024 19:36
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from 075f1f4 to 5473626 Compare October 14, 2024 18:45
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from 5473626 to b20ed68 Compare November 16, 2024 09:49
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from b20ed68 to 44de02d Compare December 28, 2024 08:55
@beutlich beutlich mentioned this pull request Dec 28, 2024
Open
@beutlich beutlich force-pushed the add-top-level-license-annotation branch from 44de02d to 569c907 Compare January 15, 2025 20:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tobolar tobolar tobolar left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
requires Modelica 3.7 Issue that requires Modelica Language Specification 3.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beutlich @tobolar