Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proposed changes quantization #4460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HansOlsson
Copy link
Contributor

Improvements:

  • Correct number of output levels.
  • Handles non-symmetric limits.

Closes #4459

Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@dietmarw
Copy link
Member

Which milestone is this supposed to be part of?

@HansOlsson
Copy link
Contributor Author

Which milestone is this supposed to be part of?

Good question. The dead-lines for 4.1.0 have passed and it isn't super-urgent to me, but I leave the decision to @casella
I don't think it is a breaking change that should wait until version 5.

@dietmarw
Copy link
Member

Well if it isn't urgent then it should go in the next (does not need to be a major). Otherwise you never going to get 4.1.0 out of the door ;-)

@casella
Copy link
Contributor

casella commented Sep 18, 2024

No milestone means not in 4.1.0. I'll put it in the next minor.

@casella casella added this to the MSL4.2.0 milestone Sep 18, 2024
@dietmarw
Copy link
Member

No milestone means not in 4.1.0. I'll put it in the next major.

you mean minor I guess.

@beutlich beutlich added the L: Clocked Issue addresses Modelica.Clocked label Oct 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
L: Clocked Issue addresses Modelica.Clocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quantization may output more levels than the number of bits allows
5 participants