Add security check to see if a URL is pointing to internal IP #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbc2016
reviewed
Aug 29, 2024
| url (str): url to be checked | ||
|
|
||
| Returns: | ||
| bool: True if url is not to interal IP addresses, |
There was a problem hiding this comment.
remove "not" ？And typo "interal" here and above
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Add security check to see if a URL is pointing to internal IP
about: Create a pull request
Description
As title, and linked to #412
Checklist
Please check the following items before code is ready to be reviewed.