fix(GridIntersect): fix vertices for offset grids #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(misc): clean up docstrings
for unsupported methods
ensure one entry per grid cell in polygon intersection result add test for this case
bug in structured mode where linestrings were not handled correctly if they pass in and out of grid cell
- fix vertices when intersecting linestring with offset grids
Codecov Report
@@ Coverage Diff @@
## develop #1037 +/- ##
=========================================
Coverage 73.302% 73.302%
=========================================
Files 225 225
Lines 50791 50791
=========================================
Hits 37231 37231
Misses 13560 13560
|
|
Thanks @dbrakenhoff and @mkennard-aquaveo! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix how vertices are returned when intersecting linestrings with offset grids.
See #1035