-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(utils/check) file check for mfusg unstructured models #1145
fix(utils/check) file check for mfusg unstructured models #1145
Conversation
Chris - I rejigged this PR based on your review of #1076. I decided not to move the get_neighbors function to the grid classes because these seem designed to be independent of the model class, and I would need access to the model class / disu for get_neighbors. I was wary of changing this but let me know if you still prefer it to be moved out of utils/check. |
mfusg file checking did not previously work * add get_neighbors function clause for mfusg unstructured grids (in check class, but not mf6check) * add modflow/mfdisu/_get_neighboring_nodes function * fix pakbase/_check_flowp hk and vka for unstructured cases * modify modflow/mfbas/check function to cater for mfusg unstructured grids, in addition to structured modflow grids * modify t016_test.py to cater for modflow/mfdisu/_get_neighboring_nodes function Resolves #1072
Codecov Report
@@ Coverage Diff @@
## develop #1145 +/- ##
=============================================
+ Coverage 72.068% 73.576% +1.507%
=============================================
Files 225 225
Lines 51962 50878 -1084
=============================================
- Hits 37448 37434 -14
+ Misses 14514 13444 -1070
|
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Hey @cnicol-gwlogic, I took a quick look through this, and it looks like you've made some nice improvements. Is there one or more simple tests that show that this is all working as intended? Or do you think the t016_test is sufficient? |
Hi @langevin-usgs, yep sorry - should have thought of that, given that's how I was testing the changes at my end. doh.See last commit. I've got a couple more tests ready for another PR that will add RCH and EVT loading capability. Cheers. |
mfusg file checking did not previously work
structured modflow grids
Resolves #1072, although issues still need to be addressed to enable loading RCH and EVT, so users will need to use "load_only=[]" to avoid trying to load those for now.